Peter/river exceptions not excepting #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter-zhong-replit
requested review from
jackyzha0
and removed request for
a team
jackyzha0
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We validate the errors which might have some schema like extra fields, then we toss them away like unwanted trash. This is bad.
What changed
The RiverServiceException class is updated to accept and store the original deserialized RiverError object.
Client sessions now pass this underlying_error when raising service exceptions, making the full error payload accessible.
Test plan
Ran ai-infra with this. The CI/CD for that will catch anything and it's also like low key just adding stuff.